fix #8846 [Backport 2.1-develop]: avoid duplicated attribute option values#11786
Merged
magento-team merged 1 commit intomagento:2.1-developfrom Nov 7, 2017
Merged
fix #8846 [Backport 2.1-develop]: avoid duplicated attribute option values#11786magento-team merged 1 commit intomagento:2.1-developfrom
magento-team merged 1 commit intomagento:2.1-developfrom
Conversation
okorshenko
added
Release Line: 2.1
2.2.x
bug report
Reproduced on 2.1.x
magento-team
added
Progress: needs update
Progress: accept
and removed
Progress: needs update
labels
magento-team
pushed a commit
that referenced
this pull request
Nov 7, 2017
…ribute option values #11786
magento-team
pushed a commit
that referenced
this pull request
Nov 7, 2017
[EngCom] Public Pull Requests - 2.1-develop - MAGETWO-83320: #7903 correct the position of the datepicker when you scroll #12045 - MAGETWO-83319: [backport 2.1] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12040 - MAGETWO-82948: fix #8846 [Backport 2.1-develop]: avoid duplicated attribute option values #11786 - MAGETWO-81328: [Fix:5439] Send email to subscribers only when are new 2.1 #11316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… #8846
Description
When adding an attribute option, check if its label exists for current attribute. If so, doesn't add the option and return false.
Fixed Issues
Manual testing scenarios
Same testing described at issues #8846. Add an attribute option via API twice.
Contribution checklist